Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send ecash component #68

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

toyota-corolla0
Copy link
Contributor

addresses #19

Currently this overflows the text on the menu a bit. I like the idea of the menu having a "Send" and "Receive" tab, under which you will be able to find the 3 methods of ecash, lightning network, and onchain. @elsirion what do you think?

also renamed a few components
let notes_string_signal = Signal::derive(move || notes.to_string());
view! {
<SuccessBlock>
{format!("Notes representing {} shown below.", total)}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should warn if that value is larger than what the user requested? This can happen if we run out of denominations and it's the application's responsibility to detect that and deal with it.

Comment on lines +93 to +95
<QrCode
data=notes_string_signal
/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I we want to be really fancy we could look into using https://github.com/gre/qrloop, that's the thing Fedi uses

@elsirion elsirion merged commit 39791f2 into elsirion:master Feb 26, 2024
1 check passed
@toyota-corolla0 toyota-corolla0 deleted the 2024-02-ecash-send branch February 26, 2024 20:59
@elsirion
Copy link
Owner

Currently this overflows the text on the menu a bit. I like the idea of the menu having a "Send" and "Receive" tab, under which you will be able to find the 3 methods of ecash, lightning network, and onchain. @elsirion what do you think?

Sounds good to me, I tried to draw some mock ups but they always looked horrible, so I didn't try that out yet. I was also considering moving the menu down, so it's more like an app when run as a PWA. Curious what you come up with.

Untitled Diagram drawio(4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants